Skip to content

remove PoW RPC method eth_coinbase #9487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
macfarla merged 3 commits into from
Nov 25, 2025
Merged

remove PoW RPC method eth_coinbase #9487

macfarla merged 3 commits into from
Nov 25, 2025

Conversation

@macfarla
Copy link
Contributor

@macfarla macfarla commented Nov 24, 2025 •
edited
Loading

PR description

coinbase exists now only for clique, and it is set to a constant value for the local node.

Related: #9486 removing the CLI options that can configure this value.

Fixed Issue(s)

refs #9454

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

@macfarla
remove PoW RPC method eth_coinbase
053973c 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Copilot AI review requested due to automatic review settings November 24, 2025 04:34
@macfarla
changelog
840ba77 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla added doc-change-required Indicates an issue or PR that requires doc to be updated breaking This can only be addressed/merged for a release that allows user-facing changes to be breaking. labels Nov 24, 2025
Copilot AI reviewed Nov 24, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jframe jframe self-assigned this Nov 24, 2025
@macfarla macfarla enabled auto-merge (squash) November 25, 2025 00:06
@macfarla macfarla merged commit 2379336 into hyperledger:main Nov 25, 2025
46 checks passed
@macfarla macfarla mentioned this pull request Nov 25, 2025
Open
42 tasks
@macfarla macfarla deleted the remove-eth-coinbase-rpc branch November 25, 2025 04:02
@alexandratran alexandratran mentioned this pull request Nov 28, 2025
Closed
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Nov 28, 2025
pinges pushed a commit to pinges/besu that referenced this pull request Dec 15, 2025
@macfarla @pinges
remove PoW RPC method eth_coinbase (hyperledger#9487)
3e3f292 
* remove PoW RPC method eth_coinbase

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jframe jframe jframe approved these changes

Assignees

@jframe jframe

Labels

breaking This can only be addressed/merged for a release that allows user-facing changes to be breaking.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@macfarla @jframe @alexandratran