Improve performance of peerselector peers #9586
Conversation
…useless responses for some invalid responses Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…r task feature toggle in BackwardSyncStep Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
|
Performance between test and control nodes looks to be the same now |
|
Do you have times for BWS header download with and without your PR for comparison? |
|
Control node BWS header download was pretty consistant around 20 minutes. With these changes, they're both around the 20 minute mark. |
…uses memory leaks Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
…tor-peers' into improve-performance-of-peerselector-peers
…if it causes memory leaks" This reverts commit b9188d7. Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Matilda-Clerke
force-pushed
the
improve-performance-of-peerselector-peers
branch
from
0d1d1b9 to
8ef2bc5
Compare
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
pinges
left a comment
pinges
left a comment
There was a problem hiding this comment.
Good to merge if you have a good answer for my question :-)
| TOO_MANY_RESULTS_RETURNED(null), | ||
| RESULTS_DO_NOT_MATCH_QUERY(null), | ||
| NO_RESULTS_RETURNED(null, true), | ||
| TOO_MANY_RESULTS_RETURNED(null, false), |
There was a problem hiding this comment.
Why do we not record a useless response when there are too many results returned?
There was a problem hiding this comment.
Tbh I was mostly just guessing. Assuming the results returned contains the results we expected, plus others, it's still useful.
There was a problem hiding this comment.
Looking at the code it looks like we are not making use of the response when the validation response is TOO_MANY_RESULTS_RETURNED. So I guess it should at least be a useless response.
3 participants
PR description
Improve performance during backward sync by using bestPeerComparator. Also implement recording useless responses from peers in PeerTaskExecutor to eventually disconnect bad peers.