fix: copy blobGasUsed in BlockHeaderBuilder.fromBuilder() #9595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lder() Signed-off-by: emmmm <155267286+eeemmmmmm@users.noreply.github.com>
macfarla
approved these changes
Jan 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that fromBuilder() method was missing the blobGasUsed field when copying builder state. All other blob-related fields (excessBlobGas, parentBeaconBlockRoot) were being copied correctly, but blobGasUsed was skipped.
This is clearly a copy-paste oversight - you can see the pattern in other similar methods like fromHeader() and populateFrom() where blobGasUsed is always copied alongside excessBlobGas.
Without this fix, any code using fromBuilder() to clone a BlockHeaderBuilder would lose the blobGasUsed value, potentially causing issues with blob transaction block headers.