Skip to content

Conversation

@macfarla
Copy link
Contributor

@macfarla macfarla commented Jan 6, 2026

PR description

Check fromBlock and toBlock to ensure fromBlock <= toBlock <= latest block.
Added this validation as a method on FilterParameter, however it's not super clean because the from/to can be "safe", "finalized" etc so this can really only be validated once they are resolved to numeric values.

Fixed Issue(s)

This will fix 2 hive tests

eth_getLogs/filter-error-future-block-range 
eth_getLogs/filter-error-reversed-block-range 

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla added breaking This can only be addressed/merged for a release that allows user-facing changes to be breaking. hive relating to hive tests labels Jan 6, 2026
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
…s for this from 32 to 8

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking This can only be addressed/merged for a release that allows user-facing changes to be breaking. hive relating to hive tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant