Fix minor TypeScript issues and add ESLint TypeScript support#418
Fix minor TypeScript issues and add ESLint TypeScript support#418bestbeforetoday merged 14 commits intohyperledger:mainfrom
Conversation
Add "../../types/" as type package to **/test/typescript/tsconfig.json Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
bestbeforetoday
left a comment
There was a problem hiding this comment.
Thank you very much for these changes! Just two things to note:
- There seem to be some indentation issues in
tsconfig.jsonfiles. I think caused by mixed spaces and tabs for indentation. This should be fixed. - Ideally the
tsconfig.jsonfiles would make use of the standard base configuration for Node 18 (see here). This might cause issues with the requiredtypescriptversion, which might in turn cause issues with the requiredeslintversion. This could happen outside of this PR.
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
|
Thank you for your review. Firstly, I fixed all tsconfig.json files with 2-spaces indentation. Please check again. Secondly, the content of all new tsconfig.json was copied from |
bestbeforetoday
left a comment
There was a problem hiding this comment.
It's probably better to consider using @tsconfig/node18 separately from this pull request so the current change looks good to me.
Thank you for the contribution!
Closes #415 #416 #417