Relax grpc-js version constraint in fabric-shim#437
Merged
bestbeforetoday merged 1 commit intohyperledger:mainfrom Sep 27, 2024
Merged
Relax grpc-js version constraint in fabric-shim#437bestbeforetoday merged 1 commit intohyperledger:mainfrom
bestbeforetoday merged 1 commit intohyperledger:mainfrom
Conversation
bestbeforetoday
force-pushed
the
grpc-version
branch
3 times, most recently
from
fb20564 to
e36f0db
Compare
When different versions of @grpc/grpc-js are resolved in the dependency
tree, the following error in the chaincode can prevent the chaincode
container from starting:
TypeError: Channel credentials must be a ChannelCredentials object
This is typically caused by a mismatch between the versions of
@grpc/grpc-js specified by fabric-shim and @hyperledger/fabric-protos.
Provided the version constraints are loose enough to allow a single
version to satisfy both dependencies, the mismatch can be avoided by
deduping dependencies in a consuming chaincode.
This change relaxes the @grpc/grpc-js version constraint in fabric-shim
to allow compatibility with any newer minor release version specified by
@hyperledger/fabric-protos.
Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
bestbeforetoday
force-pushed
the
grpc-version
branch
from
e36f0db to
7500873
Compare
bestbeforetoday
commented
Sep 27, 2024
| return mapped; | ||
| }); | ||
|
|
||
| speObject.rule.signedBy = spe.getRule().getSignedBy(); |
Member
Author
There was a problem hiding this comment.
This line is the only actual change in this file. The rest is just formatting.
It seems newer binding defaulted the value of speObject.rule.signedBy to undefined instead of 0 when created by spe.toObject() in the test code above. This change just explicitly copies the actual value instead of relying on a default, and is probably how it should always have been done.
Note that this is just a change to how the test code collects the protobuf state before the equality test below. No change to the implementation code.
denyeart
reviewed
Sep 28, 2024
Contributor
denyeart
left a comment
denyeart
left a comment
There was a problem hiding this comment.
Thanks Mark, looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When different versions of @grpc/grpc-js are resolved in the dependency tree, the following error in the chaincode can prevent the chaincode container from starting:
This is typically caused by a mismatch between the versions of @grpc/grpc-js specified by fabric-shim and @hyperledger/fabric-protos. Provided the version constraints are loose enough to allow a single version to satisfy both dependencies, the mismatch can be avoided by deduping dependencies in a consuming chaincode.
This change relaxes the @grpc/grpc-js version constraint in fabric-shim to allow compatibility with any newer minor release version specified by @hyperledger/fabric-protos.
Closes #408