Remove the last vestiges of autodetecting heap/stack size from exes #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we supported loading guest binaries from PE files, we also supported autodetecting reasonable defaults for heap and stack size for the sandbox based on the loaded executable's stack/heap size hints. ELF files did not have a similar convention for stack/heap size hints embedded in the file, so when loading an ELF file, we just used some vaguely reasonable small defaults (64k stack and 128k heap). Now that PE support is gone, these are in fact the defaults used for /all/ files, so it doesn't make much sense that we bother putting them into an executable information structure and passing it around. This commit removes that vestigial use of the ExeInfo structure, replacing it with defaults inline in `sandbox::config`. Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
added
the
kind/enhancement
simongdavies
requested review from
dblnz,
devigned,
jprendes,
ludfjig,
marosset and
syntactically
as code owners
7 tasks
jsturtevant
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we supported loading guest binaries from PE files, we also supported autodetecting reasonable defaults for heap and stack size for the sandbox based on the loaded executable's stack/heap size hints. ELF files did not have a similar convention for stack/heap size hints embedded in the file, so when loading an ELF file, we just used some vaguely reasonable small defaults (64k stack and 128k heap). Now that PE support is gone, these are in fact the defaults used for /all/ files, so it doesn't make much sense that we bother putting them into an executable information structure and passing it around. This commit removes that vestigial use of the ExeInfo structure, replacing it with defaults inline in
sandbox::config.