-
-
Notifications
You must be signed in to change notification settings - Fork 78
Conversation
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #150 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 7 7
Lines 330 330
=======================================
Hits 312 312
Misses 18 18 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Thank @artivis, this looks great! We will find a Linux machine with discrete GPUs to test it. |
peakji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We can tweak minor issues like the default branch name and access token name later. If @artivis confirms that the download command is okay, then let's merge! 🚀
|
Thanks for the quick review. |
fardeon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Hi @artivis ! Sorry to bother you again, but we need some help regarding snap. After this PR is merged, we did some cleanup to only build and publish on release. The first run of the workflow went smoothly, and I could see the package uploaded and waiting for release on the snapcraft web interface. However, the workflow has been failing since then, and we're a bit lost... This is our first time to publish a package on snapcraft, and we appreciate your guidance! 🙏 |
|
Hey there no problem. Looking at the failing job, it seems that you had a heavy hand while cleaning up. Indeed the variable This being said, my bad for not giving you more context for this PR. Snaps come with a whole release management system baked in. One can manage several releases of one's app depending on the status of the development stable/candidate/beta/edge. To publish to stable/candidate, the snap grade must be marked as 'stable'. That's what's happening here on: the snap is marked as 'stable' solely on tags, therefore preventing to push ongoing developments to the stable/candidate releases. Similarly, the ci originally built the snap for all change pushed to the master branch, but would push on-going development (no-tag) to That's really one release management schema, others are definitely possible. If you have further questions, feel free to ping me :) |
|
Thank you for such a detailed response!
Oh I see! I thought the
This design is great! I'll test it on the web interface. We plan to gradually optimize our release process after implementing the chat API. |
This PR adds snap packaging which (eventually) allows to easily install the app on dozens on Linux distro,
Run it then with,
The snap sets by default,
PORT=8080since 80 requiressudoMODEL_CACHE_DIR=~/snap/basaran/common/modelsSERVER_THREADS=4They all can be overloaded by the user through the usual environment variables.
Together with the packaging comes a new workflow that runs the packaging and push the artifacts to the store. This being said, you would have to create an account on the store and generate a access token.
Note that I could only test it on my laptop (no discrete gpu) and thus may require some tweaking.