Use specific version for docker image

.github/workflows/build.yml

@@ -6,34 +6,26 @@ jobs:
 
   build:
     runs-on: ubuntu-latest
-    container: nastyabirillo/hyperstyle
-
+    # Consistent with Version.md
+    container: nastyabirillo/hyperstyle:1.2.0
+
     steps:
 
       - name: Checkout
         uses: actions/checkout@v1
-
-#     Note: The original Dockerfile for this action contains the following commands to install numpy and pandas. 
-#     We exclude them from production to compress the docker image
 
-#      RUN apk add --no-cache python3-dev libstdc++ && \
-#          apk add --no-cache g++ && \
-#          ln -s /usr/include/locale.h /usr/include/xlocale.h && \
-#          pip3 install numpy && \
-#          pip3 install pandas
-
       - name: Lint with flake8
         run: |
           # stop the build if there are Python syntax errors or undefined names
           flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics --exclude=.git,__pycache__,docs/source/conf.py,old,build,dist,venv,test/resources,.eggs,review.egg-info,.pytest_cache,node_modules
           # TODO: change max-complexity into 10 after refactoring
           flake8 . --count --max-complexity=11 --max-line-length=120 --max-doc-length=120 --ignore=R504,A003,E800,E402,W503,WPS,H601 --statistics --exclude=.git,__pycache__,docs/source/conf.py,old,build,dist,venv,test/resources,.eggs,review.egg-info,.pytest_cache,node_modules
-      
+
       - name: Set up Eslint
         run: |
           npm install eslint --save-dev
           ./node_modules/.bin/eslint --init
-      
+
       - name: Test with pytest
         run: |
             pytest

Dockerfile

@@ -1,3 +1,5 @@
+# This Dockerfile is used only for production
+
 FROM python:3.8.2-alpine3.11
 
 RUN apk --no-cache add openjdk11 --repository=http://dl-cdn.alpinelinux.org/alpine/edge/community \
@@ -8,9 +10,12 @@ RUN npm i -g eslint@7.5.0
 RUN java -version
 RUN ls /usr/lib/jvm
 
-## Other dependencies
+# Other dependencies
 RUN apk add bash
 
+# Set up Eslint
+RUN npm install eslint --save-dev && ./node_modules/.bin/eslint --init
+
 # Upgrade pip
 RUN python3.8 -m pip install --upgrade pip
 
@@ -33,4 +38,4 @@ RUN pip3 install --no-cache-dir ./review
 ENV JAVA_HOME=/usr/lib/jvm/java-11-openjdk
 ENV PATH="$JAVA_HOME/bin:${PATH}"
 
-CMD ["/bin/bash"]
+CMD ["/bin/bash"]

README.md

@@ -198,7 +198,7 @@ __Note__: If you have `ModuleNotFoundError` while you try to run tests, please c
 __Note__: We use [eslint](https://eslint.org/) and [open-jdk 11](https://openjdk.java.net/projects/jdk/11/)
 in the tests. Please, set up the environment before running the tests. 
 You can see en example of the environment configuration in 
-the [build.yml](./.github/workflows/build.yml) file.
+the [Dockerfile](./docker/dev/Dockerfile) file.
 
 Use `pytest` from the root directory to run __ALL__ tests.
 

docker/dev/Dockerfile

@@ -0,0 +1,37 @@
+FROM python:3.8.2-alpine3.11
+
+RUN apk --no-cache add openjdk11 --repository=http://dl-cdn.alpinelinux.org/alpine/edge/community \
+    && apk add --update nodejs npm
+
+RUN npm i -g eslint@7.5.0
+
+RUN java -version
+RUN ls /usr/lib/jvm
+
+# Install numpy and pandas for tests
+RUN apk add --no-cache python3-dev libstdc++ && \
+    apk add --no-cache g++ && \
+    ln -s /usr/include/locale.h /usr/include/xlocale.h && \
+    pip3 install numpy && \
+    pip3 install pandas
+
+# Other dependencies
+RUN apk add bash
+
+# Dependencies and package installation
+WORKDIR /
+
+COPY requirements-test.txt review/requirements-test.txt
+RUN pip3 install --no-cache-dir -r review/requirements-test.txt
+
+COPY requirements.txt review/requirements.txt
+RUN pip3 install --no-cache-dir -r review/requirements.txt
+
+COPY . review
+RUN pip3 install --no-cache-dir ./review
+
+# Container's enviroment variables
+ENV JAVA_HOME=/usr/lib/jvm/java-11-openjdk
+ENV PATH="$JAVA_HOME/bin:${PATH}"
+
+CMD ["/bin/bash"]

requirements.txt

@@ -27,4 +27,4 @@ radon==4.5.0
 # extra libraries and frameworks
 django==3.2
 requests==2.25.1
-argparse==1.4.0
+argparse==1.4.0

src/python/review/inspectors/flake8/issue_types.py

@@ -27,10 +27,6 @@
     'C818': IssueType.CODE_STYLE,
     'C819': IssueType.CODE_STYLE,
 
-    # flake8-spellcheck
-    'SC100': IssueType.INFO,
-    'SC200': IssueType.INFO,
-
     # WPS: Naming
     'WPS117': IssueType.CODE_STYLE,  # Forbid naming variables self, cls, or mcs.
     'WPS125': IssueType.ERROR_PRONE,  # Forbid variable or module names which shadow builtin names.
@@ -111,7 +107,7 @@
 
     'F': IssueType.BEST_PRACTICES,  # standard flake8
     'C': IssueType.BEST_PRACTICES,  # flake8-comprehensions
-    'SC': IssueType.BEST_PRACTICES,  # flake8-spellcheck
+    'SC': IssueType.INFO,  # flake8-spellcheck
 
     'WPS1': IssueType.CODE_STYLE,  # WPS type: Naming
     'WPS2': IssueType.COMPLEXITY,  # WPS type: Complexity

src/python/review/reviewers/perform_review.py

@@ -6,6 +6,7 @@
 
 from src.python.review.application_config import ApplicationConfig
 from src.python.review.common.language import Language
+from src.python.review.inspectors.issue import IssueType
 from src.python.review.reviewers.common import perform_language_review
 from src.python.review.reviewers.python import perform_python_review
 from src.python.review.reviewers.review_result import ReviewResult
@@ -66,7 +67,8 @@ def perform_and_print_review(path: Path,
     else:
         print_review_result_as_text(review_result, path)
 
-    return len(review_result.all_issues)
+    # Don't count INFO issues too
+    return len(list(filter(lambda issue: issue.type != IssueType.INFO, review_result.all_issues)))
 
 
 def perform_review(path: Path, config: ApplicationConfig) -> ReviewResult: