Skip to content

Issue #87 fix #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nbirillo merged 2 commits into from
Aug 3, 2021
Merged

Issue #87 fix #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
916da44
Fixed issue #87
GirZ0n Aug 3, 2021
8a5928d
Added test
GirZ0n Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/python/review/inspectors/checkstyle/files/config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,9 @@
<module name="MissingSwitchDefault"/>
<module name="ModifiedControlVariable"/>
<module name="MultipleStringLiterals">
<property name="allowedDuplicates" value="2"/>
<property name="ignoreStringsRegexp" value="^.{1,5}$"/>
<!-- Consistent with AvoidDuplicateLiterals from PMD -->
<property name="allowedDuplicates" value="3"/>
<property name="ignoreStringsRegexp" value='^".{0,2}"$'/>
</module>
<module name="MultipleVariableDeclarations"/>
<module name="NoFinalizer"/>
Expand Down
1 change: 1 addition & 0 deletions test/python/inspectors/test_checkstyle_inspector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
('test_indentation_with_spaces.java', 0),
('test_indentation_with_tabs.java', 0),
('test_indentation_google_style.java', 4),
('test_multiple_literals.java', 1),
]


Expand Down
1 change: 1 addition & 0 deletions test/python/inspectors/test_pmd_inspector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
('test_valid_curly_braces.java', 0),
('test_when_only_equals_overridden.java', 1),
('test_valid_spaces.java', 0),
('test_multiple_literals.java', 1),
]


Expand Down
32 changes: 32 additions & 0 deletions test/resources/inspectors/java/test_multiple_literals.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
class Main {
public static void main(String[] args) {
// ok
String shortRareLiteral1 = "12";
String shortRareLiteral2 = "12";
String shortRareLiteral3 = "12";

// ok
String longRareLiteral1 = "123";
String longRareLiteral2 = "123";
String longRareLiteral3 = "123";

// ok
String shortFrequentLiteral1 = "34";
String shortFrequentLiteral2 = "34";
String shortFrequentLiteral3 = "34";
String shortFrequentLiteral4 = "34";

// warning
String longFrequentLiteral1 = "456";
String longFrequentLiteral2 = "456";
String longFrequentLiteral3 = "456";
String longFrequentLiteral4 = "456";

System.out.println(
shortRareLiteral1 + shortRareLiteral2 + shortRareLiteral3 +
longRareLiteral1 + longRareLiteral2 + longRareLiteral3 +
shortFrequentLiteral1 + shortFrequentLiteral2 + shortFrequentLiteral3 + shortFrequentLiteral4 +
longFrequentLiteral1 + longFrequentLiteral2 + longFrequentLiteral3 + longFrequentLiteral4
);
}
}