This repository was archived by the owner on Apr 19, 2023. It is now read-only.
🚧 New way for adding navigation bar elements#3
Merged
alexmodrono merged 2 commits intov0.1.0/b181221from Dec 26, 2021
Merged
Conversation
…created. BREAKING CHANGE: now navigation bar elements are passed as arguments to the style, so `.navigationBarElement()` is no longer used.
alexmodrono
added
the
enhancement
alicerunsonfedora
previously requested changes
Dec 26, 2021
Member
alicerunsonfedora
left a comment
alicerunsonfedora
left a comment
There was a problem hiding this comment.
Overall looks good, but I'd consider swapping trailing and leading elements in the corresponding signatures.
alicerunsonfedora
dismissed
their stale review
Accidentally clicked wrong option
alicerunsonfedora
approved these changes
Dec 26, 2021
Member
Author
|
Alright, I'll merge this then. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Overview
This PR makes the following changes:
.navigationBarElement()no longer works (the function is still there though it will probably be deleted before the final version).NavigationBarProxy.Does this PR fix, close, or implement any issues?
Pending for review
@hyperspacedev/swiftui