Skip to content

Add javaagent config with filter jars #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shashank11p merged 3 commits into from
Feb 10, 2021
Merged

Add javaagent config with filter jars #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d8d33f
adding javaagent config
shashank11p Feb 5, 2021
e70cd92
updating javaagent filter jar paths config
shashank11p Feb 8, 2021
ad8854b
fixing comment
shashank11p Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ENV_VARS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,4 @@ Agents can be configured using environment variables:
| HT_DATA_CAPTURE_RPC_BODY_RESPONSE | When `false` it disables the capture for the response in a client/request operation |
| HT_DATA_CAPTURE_BODY_MAX_SIZE_BYTES | Maximum size of captured body in bytes. Default should be 131_072 (128 KiB). |
| HT_ENABLED | When `false`, disables the agent |
| HT_JAVAAGENT_FILTER_JAR_PATHS | Is the list of path to filter jars, separated by `,` |
9 changes: 9 additions & 0 deletions config.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ message AgentConfig {

// when `false`, disables the agent
google.protobuf.BoolValue enabled = 5;

// javaagent has the configs specific to javaagent
JavaAgent javaagent = 6;
}

// Reporting covers the options related to the mechanics for sending data to the
Expand Down Expand Up @@ -95,3 +98,9 @@ enum PropagationFormat {
// see https://www.w3.org/TR/trace-context/
TRACECONTEXT = 1;
}

// JavaAgent has the configs specific to javaagent
message JavaAgent {
// filter_jar_paths is the list of path to filter jars, separated by `,`
Copy link
Copy Markdown
Contributor

@jcchavezs jcchavezs Feb 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separated by , is a env var detail so I would remove it.

repeated google.protobuf.StringValue filter_jar_paths = 1;
}