Skip to content

Revert "BulkEntityUpdate API"#120

Merged
ankitchoudhary111 merged 1 commit intomainfrom
revert-119-bulkupdate
Aug 2, 2021
Merged

Revert "BulkEntityUpdate API"#120
ankitchoudhary111 merged 1 commit intomainfrom
revert-119-bulkupdate

Conversation

@ankitchoudhary111
Copy link
Copy Markdown
Contributor

Reverts #119

@ankitchoudhary111 ankitchoudhary111 requested review from a team and skjindal93 August 2, 2021 06:23
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 2, 2021

Codecov Report

Merging #120 (de3a485) into main (f93d501) will increase coverage by 1.23%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #120      +/-   ##
============================================
+ Coverage     58.53%   59.77%   +1.23%     
  Complexity      295      295              
============================================
  Files            39       39              
  Lines          3051     2978      -73     
  Branches        376      368       -8     
============================================
- Hits           1786     1780       -6     
+ Misses         1093     1026      -67     
  Partials        172      172              
Flag Coverage Δ
integration 59.77% <0.00%> (+1.23%) ⬆️
unit 39.92% <0.00%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/entity/query/service/EntityQueryServiceImpl.java 76.63% <0.00%> (+19.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f93d501...de3a485. Read the comment docs.

Copy link
Copy Markdown
Contributor

@skjindal93 skjindal93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation accidentally got merged with the API changes #119

Reverting the implementation to be raised as a separate PR

@github-actions

This comment has been minimized.

@ankitchoudhary111 ankitchoudhary111 merged commit af95987 into main Aug 2, 2021
@ankitchoudhary111 ankitchoudhary111 deleted the revert-119-bulkupdate branch August 2, 2021 06:26
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 2, 2021

Unit Test Results

  30 files  ±0    30 suites  ±0   21s ⏱️ -1s
141 tests ±0  141 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit af95987. ± Comparison against base commit f93d501.

suddendust pushed a commit to suddendust/entity-service that referenced this pull request Sep 5, 2025
…o non-identifier type LHS (hypertrace#120)

* Update Postgres Filter Type Expression Parser to make it extendible to non-identifier type LHS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants