feat: refactor http operation metrics to handle multiple frameworks#202
Merged
tim-mwangi merged 5 commits intomainfrom Jan 31, 2023
Merged
feat: refactor http operation metrics to handle multiple frameworks#202tim-mwangi merged 5 commits intomainfrom
tim-mwangi merged 5 commits intomainfrom
Conversation
This is to be able to send the correct operation name from the various frameworks including gorilla mux. Also, remove the otel metrics specific code from the sdk.
Codecov Report
@@ Coverage Diff @@
## main #202 +/- ##
==========================================
- Coverage 64.99% 58.19% -6.80%
==========================================
Files 49 55 +6
Lines 1774 2220 +446
==========================================
+ Hits 1153 1292 +139
- Misses 570 868 +298
- Partials 51 60 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
prodion23
approved these changes
Jan 31, 2023
ryanericson
approved these changes
Jan 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is to be able to send the correct operation name from the various frameworks including gorilla mux. Also, remove the otel metrics specific code from the sdk.
Testing
Checklist: