Skip to content

feat: refactor http operation metrics to handle multiple frameworks#202

Merged
tim-mwangi merged 5 commits intomainfrom
metrics-round-3
Jan 31, 2023
Merged

feat: refactor http operation metrics to handle multiple frameworks#202
tim-mwangi merged 5 commits intomainfrom
metrics-round-3

Conversation

@tim-mwangi
Copy link
Copy Markdown
Collaborator

Description

This is to be able to send the correct operation name from the various frameworks including gorilla mux. Also, remove the otel metrics specific code from the sdk.

Testing

  • Tested locally

Checklist:

  • [✅ ] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [✅ ] Any dependent changes have been merged and published in downstream modules

This is to be able to send the correct operation name from the various frameworks including gorilla mux.
Also, remove the otel metrics specific code from the sdk.
@tim-mwangi tim-mwangi marked this pull request as ready for review January 30, 2023 21:13
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 30, 2023

Codecov Report

Merging #202 (e66a39a) into main (c886e58) will decrease coverage by 6.80%.
The diff coverage is 33.26%.

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   64.99%   58.19%   -6.80%     
==========================================
  Files          49       55       +6     
  Lines        1774     2220     +446     
==========================================
+ Hits         1153     1292     +139     
- Misses        570      868     +298     
- Partials       51       60       +9     
Impacted Files Coverage Δ
...nstrumentation/hypertrace/net/hyperhttp/handler.go 0.00% <0.00%> (ø)
instrumentation/opencensus/metrics.go 0.00% <0.00%> (ø)
...ntation/opentelemetry/batchspanprocessor/logger.go 0.00% <0.00%> (ø)
instrumentation/opentelemetry/metrics.go 0.00% <0.00%> (ø)
...atchspanprocessor/batch_span_processor.modified.go 15.67% <15.67%> (ø)
...n/opentelemetry/batchspanprocessor/env.modified.go 30.23% <30.23%> (ø)
instrumentation/opentelemetry/init_additional.go 79.10% <70.00%> (+1.32%) ⬆️
instrumentation/opentelemetry/init.go 81.18% <78.04%> (-1.33%) ⬇️
...nstrumentation/opencensus/net/hyperhttp/handler.go 100.00% <100.00%> (ø)
...ion/opentelemetry/batchspanprocessor/bspcreator.go 100.00% <100.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tim-mwangi tim-mwangi requested a review from tyroneyu January 31, 2023 16:06
@tim-mwangi tim-mwangi merged commit 9dc499c into main Jan 31, 2023
@tim-mwangi tim-mwangi deleted the metrics-round-3 branch January 31, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants