Conversation
tyroneyu
force-pushed
the
bump-otel-1.12.0
branch
from
534929a to
d83549a
Compare
| go.opentelemetry.io/otel/metric v0.31.0 | ||
| go.opentelemetry.io/otel/sdk v1.10.0 | ||
| go.opentelemetry.io/otel/trace v1.10.0 | ||
| google.golang.org/grpc v1.49.0 |
There was a problem hiding this comment.
Need to bump metrics as well to the corresponding version: i.e go.opentelemetry.io/otel/metric I believe it's v0.35.0 https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.12.0
There was a problem hiding this comment.
Thanks! that was the hint that I needed. I also had to bump up the contrib versions as well.
Codecov Report
@@ Coverage Diff @@
## main #204 +/- ##
==========================================
+ Coverage 58.23% 58.37% +0.13%
==========================================
Files 55 55
Lines 2229 2222 -7
==========================================
- Hits 1298 1297 -1
+ Misses 870 866 -4
+ Partials 61 59 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| strategy: | ||
| matrix: | ||
| go: ["1.17", "1.18", "1.19"] | ||
| go: ["1.18", "1.19"] |
There was a problem hiding this comment.
Done
For future reference, where did you read the 1.20 support? I used this link for reference to know 1.17 was gone. I did not see 1.20.
https://github.com/open-telemetry/opentelemetry-go
There was a problem hiding this comment.
In the compatibility it says latest version - 2. https://github.com/open-telemetry/opentelemetry-go#compatibility
There was a problem hiding this comment.
For posterity, otel hasn't updated their compatibiity chart nor their CI yet. It still only runs golang 1.18/1.19. However, golang 1.20 was released Feb 1st and otel points to https://go.dev/doc/devel/release#policy to say they support the last 2 golang versions.
It does not hurt to add this into our CI right now.
Done.
Add metric reporting config options
2 participants
Description
Bump otel to 1.12.0