Skip to content

fix: map HTTP response status code to equivalent GRPC Status code#207

Merged
tim-mwangi merged 2 commits intomainfrom
grpc-status-code
Feb 13, 2023
Merged

fix: map HTTP response status code to equivalent GRPC Status code#207
tim-mwangi merged 2 commits intomainfrom
grpc-status-code

Conversation

@tim-mwangi
Copy link
Copy Markdown
Collaborator

Description

Need to map the HTTP status code returned by the filter logic to GRPC status code for GRPC instrumentation.

Testing

Unit tests.

Checklist:

  • [ ✅ ] My changes generate no new warnings
  • [ ✅ ] I have added tests that prove my fix is effective or that my feature works
  • [✅ ] Any dependent changes have been merged and published in downstream modules

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 12, 2023

Codecov Report

Merging #207 (2404d24) into main (b433f7a) will increase coverage by 0.47%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
+ Coverage   58.91%   59.38%   +0.47%     
==========================================
  Files          55       55              
  Lines        2222     2243      +21     
==========================================
+ Hits         1309     1332      +23     
+ Misses        855      853       -2     
  Partials       58       58              
Impacted Files Coverage Δ
...k/instrumentation/google.golang.org/grpc/server.go 75.40% <100.00%> (ø)
...k/instrumentation/google.golang.org/grpc/status.go 32.53% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tim-mwangi tim-mwangi merged commit 5aad408 into main Feb 13, 2023
@tim-mwangi tim-mwangi deleted the grpc-status-code branch February 13, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants