Skip to content

fix: remove metric maps#211

Merged
tim-mwangi merged 1 commit intomainfrom
http-metrics-revisited
Feb 24, 2023
Merged

fix: remove metric maps#211
tim-mwangi merged 1 commit intomainfrom
http-metrics-revisited

Conversation

@tim-mwangi
Copy link
Copy Markdown
Collaborator

Description

Switch to struct fields. No need to use a map for static fields

Switch to struct fields
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 24, 2023

Codecov Report

Merging #211 (7fec5bd) into main (1afdcd7) will decrease coverage by 0.54%.
The diff coverage is 52.00%.

@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   59.25%   58.71%   -0.54%     
==========================================
  Files          55       55              
  Lines        2248     2231      -17     
==========================================
- Hits         1332     1310      -22     
- Misses        858      862       +4     
- Partials       58       59       +1     
Impacted Files Coverage Δ
instrumentation/opencensus/metrics.go 0.00% <ø> (ø)
instrumentation/opentelemetry/metrics.go 0.00% <0.00%> (ø)
sdk/instrumentation/net/http/handler.go 26.54% <ø> (-0.46%) ⬇️
...atchspanprocessor/batch_span_processor.modified.go 13.07% <81.25%> (-7.08%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tim-mwangi tim-mwangi merged commit a69e370 into main Feb 24, 2023
@tim-mwangi tim-mwangi deleted the http-metrics-revisited branch February 24, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants