chore: make it easier to pass resource agent name and version#212
Merged
tim-mwangi merged 2 commits intomainfrom Mar 6, 2023
Merged
chore: make it easier to pass resource agent name and version#212tim-mwangi merged 2 commits intomainfrom
tim-mwangi merged 2 commits intomainfrom
Conversation
This will make it easier for consumers of this module to pass thheir own agent names and versions.
Codecov Report
@@ Coverage Diff @@
## main #212 +/- ##
==========================================
+ Coverage 58.71% 58.73% +0.01%
==========================================
Files 55 55
Lines 2231 2232 +1
==========================================
+ Hits 1310 1311 +1
Misses 862 862
Partials 59 59
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tyroneyu
reviewed
Mar 3, 2023
| // InitWithSpanProcessorWrapper initializes opentelemetry tracing with a wrapper over span processor | ||
| // and returns a shutdown function to flush data immediately on a termination signal. | ||
| func InitWithSpanProcessorWrapper(cfg *config.AgentConfig, wrapper SpanProcessorWrapper) func() { | ||
| func InitWithSpanProcessorWrapper(cfg *config.AgentConfig, wrapper SpanProcessorWrapper, |
Contributor
There was a problem hiding this comment.
Just curious, what is the advantage of passing around the func rather than the slice?
Secondary is, can the versionInfo be const?
Collaborator
Author
There was a problem hiding this comment.
I could make it a var which will be an attribute/key-pair array.
prodion23
approved these changes
Mar 6, 2023
tyroneyu
approved these changes
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This will make it easier for consumers of this module to pass their own agent names and versions.
Testing
Unit tests and tested locally
Checklist: