Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #214 +/- ##
==========================================
- Coverage 58.73% 58.65% -0.08%
==========================================
Files 55 55
Lines 2232 2235 +3
==========================================
Hits 1311 1311
- Misses 862 865 +3
Partials 59 59
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tim-mwangi
reviewed
Jun 30, 2023
| @@ -1,3 +1,4 @@ | |||
| //go:build ignore | |||
Collaborator
There was a problem hiding this comment.
oh these are now needed?
Collaborator
Author
There was a problem hiding this comment.
Hmm,I think these were added with fmt, but we probably don't need both lines 1 & 2
Collaborator
There was a problem hiding this comment.
cool. let's remove them.
tim-mwangi
approved these changes
Jun 30, 2023
Collaborator
|
Hey @prodion23 can we file JIRA to look at some of these gosec issues? https://github.com/hypertrace/goagent/pull/214/checks?check_run_id=14688939422 Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops 1.18 support