feat: adding length method to attribute list and updating http.url attribute in net/http instrumentation#224
Merged
tim-mwangi merged 2 commits intohypertrace:mainfrom Nov 23, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
==========================================
- Coverage 58.77% 58.32% -0.45%
==========================================
Files 55 55
Lines 2205 2210 +5
==========================================
- Hits 1296 1289 -7
- Misses 850 861 +11
- Partials 59 60 +1 ☔ View full report in Codecov by Sentry. |
varkey98
commented
Nov 23, 2023
|
|
||
| url := r.URL.String() | ||
| span.SetAttribute("http.url", url) | ||
| if strings.Contains(url, "://") { |
Contributor
Author
There was a problem hiding this comment.
fixing this issue in the instrumentation itself: https://github.com/Traceableai/goagent-src/blob/2320366e224b742d023236680e7b460e4a17630f/filter/traceable/filter.go#L352
tim-mwangi
approved these changes
Nov 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist: