Skip to content

adding cpu and memory metrics#235

Merged
varkey98 merged 3 commits intohypertrace:mainfrom
thugrock7:add_cpu_and_memory_metrics
Jul 18, 2024
Merged

adding cpu and memory metrics#235
varkey98 merged 3 commits intohypertrace:mainfrom
thugrock7:add_cpu_and_memory_metrics

Conversation

@thugrock7
Copy link
Copy Markdown
Contributor

Description

Adding CPU and Memory monitoring metrics

Testing

deployed and tested locally.

Checklist:

  • My changes generate no new warnings

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

Comment thread instrumentation/opentelemetry/init.go Outdated
Copy link
Copy Markdown
Contributor

@varkey98 varkey98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls wait for a review from @tim-mwangi as well

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 70.17544% with 17 lines in your changes missing coverage. Please review.

Project coverage is 59.45%. Comparing base (4e0c822) to head (beb9f7f).

Files Patch % Lines
...n/opentelemetry/internal/metrics/system_metrics.go 69.64% 10 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
- Coverage   60.40%   59.45%   -0.95%     
==========================================
  Files          55       70      +15     
  Lines        1836     2348     +512     
==========================================
+ Hits         1109     1396     +287     
- Misses        659      867     +208     
- Partials       68       85      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread instrumentation/opentelemetry/internal/metrics/system_metrics.go Outdated
Comment thread instrumentation/opentelemetry/internal/metrics/system_metrics.go Outdated
Comment thread instrumentation/opentelemetry/internal/metrics/system_metrics.go Outdated
@tim-mwangi
Copy link
Copy Markdown
Collaborator

Strange that we do not get the reason for static analysis failure.

@tim-mwangi
Copy link
Copy Markdown
Collaborator

Let's make this configurable since in some deployments such as full TPA and ebpf, we already capture this. i.e can be disabled/enabled. We can add a system_metrics_enabled flag here https://github.com/hypertrace/agent-config/blob/1259231da9069021d09bcb6f3393275be0372582/proto/hypertrace/agent/config/v1/config.proto#L191

@varkey98
Copy link
Copy Markdown
Contributor

@ryanericson @thugrock7 merging this as we discussed yesterday during standup call

@varkey98 varkey98 merged commit 849c958 into hypertrace:main Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants