feat: updating filter result to add decorations#236
Merged
Conversation
PrajwalKrishna
approved these changes
Jul 24, 2024
Contributor
Author
|
I've updated the 2 server instrumentations we have on goagent as well to use the updated filter result, pls let me know if we want to separate it onto a different pr |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
+ Coverage 59.45% 59.89% +0.44%
==========================================
Files 70 70
Lines 2348 2364 +16
==========================================
+ Hits 1396 1416 +20
+ Misses 867 863 -4
Partials 85 85 ☔ View full report in Codecov by Sentry. |
tim-mwangi
approved these changes
Jul 24, 2024
ryanericson
approved these changes
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding a Decoration field to FilterResult. The Decoration struct can have mutations defined on request or response objects which should be applied on a filter result match. Starting with request header injections, in which a list of headers can be specified to be injected on a filter evaluation match
Checklist: