Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
+ Coverage 61.16% 61.18% +0.02%
==========================================
Files 59 59
Lines 2688 2690 +2
==========================================
+ Hits 1644 1646 +2
Misses 964 964
Partials 80 80 ☔ View full report in Codecov by Sentry. |
varkey98
left a comment
varkey98
left a comment
There was a problem hiding this comment.
Not in this pr, but I think we should exclude the examples from static analysis
Yeah. Or fix/ignore whichever errors can be ignored. |
| // | ||
| // It is up to the exporter to implement any type of retry logic if a batch is failing | ||
| // to be exported, since it is specific to the protocol and backend being sent to. | ||
| clear(bsp.batch) // Erase elements to let GC collect objects |
There was a problem hiding this comment.
Just for my understanding here, aren't we emptying the list anyways at the next line?
There was a problem hiding this comment.
Not quite. https://pkg.go.dev/builtin#clear. Clear maintains the length but sets the values to the zero values of the type in the slice.
2 participants
Description
Upgrade to otel go v1.34.0