Skip to content

Adds config support for GRPC and improves test assertions#53

Merged
jcchavezs merged 5 commits intomainfrom
config_grpc
Nov 18, 2020
Merged

Adds config support for GRPC and improves test assertions#53
jcchavezs merged 5 commits intomainfrom
config_grpc

Conversation

@jcchavezs
Copy link
Copy Markdown
Collaborator

@jcchavezs jcchavezs commented Nov 16, 2020

This PR adds support for config in GRPC and also improve test assertions to cover all attributes being added.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 18, 2020

Codecov Report

Merging #53 (4681be1) into main (85288e6) will decrease coverage by 11.03%.
The diff coverage is 93.02%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #53       +/-   ##
===========================================
- Coverage   60.67%   49.64%   -11.04%     
===========================================
  Files          24       28        +4     
  Lines         679      991      +312     
===========================================
+ Hits          412      492       +80     
- Misses        224      451      +227     
- Partials       43       48        +5     
Impacted Files Coverage Δ
sdk/google.golang.org/grpc/server.go 83.00% <87.50%> (+1.27%) ⬆️
...rumentation/opentelemetry/database/hypersql/sql.go 66.29% <100.00%> (+0.38%) ⬆️
sdk/google.golang.org/grpc/client.go 87.87% <100.00%> (+1.21%) ⬆️
sdk/internal/config/config.go 33.33% <100.00%> (ø)
sdk/net/http/handler.go 11.71% <100.00%> (ø)
sdk/net/http/transport.go 81.25% <100.00%> (ø)
sdk/net/http/attributes.go 100.00% <0.00%> (ø)
sdk/net/http/contenttype.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85288e6...4681be1. Read the comment docs.

@jcchavezs jcchavezs merged commit 3850c55 into main Nov 18, 2020
@jcchavezs jcchavezs deleted the config_grpc branch November 18, 2020 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant