feat: support internal attributes inside graphql#81
Merged
aaron-steinfeld merged 2 commits intomainfrom Oct 28, 2021
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #81 +/- ##
============================================
+ Coverage 59.12% 59.20% +0.08%
- Complexity 230 232 +2
============================================
Files 80 80
Lines 1189 1189
Branches 34 34
============================================
+ Hits 703 704 +1
+ Misses 461 460 -1
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
Contributor
|
snyk still failing |
skjindal93
approved these changes
Oct 28, 2021
Contributor
Author
Expected. Changes to workflows triggered by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, graphql never fetched internal attributes. This makes sense, because it wasn't meant to return them - but we do want to support graphql recognizing and using internal attributes internally -- that is, if it receives a request with an internal attribute, it should support that. This change allows caching the internal attributes too, but filters them before exposing them across the API.
Testing
Added UT
Checklist: