Skip to content

feat: support internal attributes inside graphql#81

Merged
aaron-steinfeld merged 2 commits intomainfrom
fetch-internal-attributes
Oct 28, 2021
Merged

feat: support internal attributes inside graphql#81
aaron-steinfeld merged 2 commits intomainfrom
fetch-internal-attributes

Conversation

@aaron-steinfeld
Copy link
Copy Markdown
Contributor

Description

Previously, graphql never fetched internal attributes. This makes sense, because it wasn't meant to return them - but we do want to support graphql recognizing and using internal attributes internally -- that is, if it receives a request with an internal attribute, it should support that. This change allows caching the internal attributes too, but filters them before exposing them across the API.

Testing

Added UT

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@github-actions

This comment has been minimized.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 27, 2021

Codecov Report

Merging #81 (b946e53) into main (2360aef) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #81      +/-   ##
============================================
+ Coverage     59.12%   59.20%   +0.08%     
- Complexity      230      232       +2     
============================================
  Files            80       80              
  Lines          1189     1189              
  Branches         34       34              
============================================
+ Hits            703      704       +1     
+ Misses          461      460       -1     
  Partials         25       25              
Flag Coverage Δ
unit 59.20% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...core/graphql/attributes/CachingAttributeStore.java 78.57% <100.00%> (+2.38%) ⬆️
...core/graphql/metadata/fetcher/MetadataFetcher.java 81.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2360aef...b946e53. Read the comment docs.

@github-actions

This comment has been minimized.

@avinashkolluru
Copy link
Copy Markdown
Contributor

snyk still failing

@aaron-steinfeld
Copy link
Copy Markdown
Contributor Author

aaron-steinfeld commented Oct 28, 2021

snyk still failing

Expected. Changes to workflows triggered by pull_request_target use the target branch (main) for context. Further reading: https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#pull_request_target

@aaron-steinfeld aaron-steinfeld merged commit f50dca8 into main Oct 28, 2021
@aaron-steinfeld aaron-steinfeld deleted the fetch-internal-attributes branch October 28, 2021 12:32
@github-actions
Copy link
Copy Markdown

Unit Test Results

30 files  ±0  30 suites  ±0   33s ⏱️ -2s
91 tests ±0  91 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f50dca8. ± Comparison against base commit 2360aef.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants