Skip to content

bugfix: Avro perf bug fix#275

Closed
laxman-traceable wants to merge 3 commits intomainfrom
perf-bug-fix
Closed

bugfix: Avro perf bug fix#275
laxman-traceable wants to merge 3 commits intomainfrom
perf-bug-fix

Conversation

@laxman-traceable
Copy link
Copy Markdown
Contributor

Description

Followup PR for hypertrace/data-model#30

Testing

Unit testing

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

NA.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 27, 2021

Codecov Report

Merging #275 (18cba64) into main (73a9194) will decrease coverage by 0.03%.
The diff coverage is 73.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #275      +/-   ##
============================================
- Coverage     80.46%   80.43%   -0.04%     
  Complexity     1209     1209              
============================================
  Files           106      106              
  Lines          4663     4671       +8     
  Branches        435      435              
============================================
+ Hits           3752     3757       +5     
- Misses          710      713       +3     
  Partials        201      201              
Flag Coverage Δ
unit 80.43% <73.33%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...raceenricher/util/EnrichedEntityAvroConverter.java 0.00% <0.00%> (ø)
...raceenricher/enrichment/AbstractTraceEnricher.java 100.00% <100.00%> (ø)
...rtrace/traceenricher/util/EntityAvroConverter.java 88.70% <100.00%> (+0.37%) ⬆️
...e/trace/accessor/entities/AvroEntityConverter.java 71.66% <100.00%> (+0.48%) ⬆️
...pannormalizer/jaeger/JaegerResourceNormalizer.java 100.00% <100.00%> (ø)
...re/spannormalizer/jaeger/JaegerSpanNormalizer.java 76.23% <100.00%> (+0.23%) ⬆️
...izer/jaeger/JaegerSpanToLogRecordsTransformer.java 89.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73a9194...18cba64. Read the comment docs.

@github-actions
Copy link
Copy Markdown

Unit Test Results

  71 files  ±0    71 suites  ±0   1m 20s ⏱️ +11s
383 tests ±0  383 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 18cba64. ± Comparison against base commit 73a9194.

@laxman-traceable
Copy link
Copy Markdown
Contributor Author

Closing the PR. Will raise another without test changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants