Skip to content

bugfix: Avro perf bug fix#277

Merged
laxman-traceable merged 2 commits intomainfrom
avro-builder-fix
Oct 28, 2021
Merged

bugfix: Avro perf bug fix#277
laxman-traceable merged 2 commits intomainfrom
avro-builder-fix

Conversation

@laxman-traceable
Copy link
Copy Markdown
Contributor

Description

Followup PR for hypertrace/data-model#30

Testing

Unit testing

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

NA.

@github-actions

This comment has been minimized.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 27, 2021

Codecov Report

Merging #277 (d2253b2) into main (be50ac2) will decrease coverage by 0.18%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #277      +/-   ##
============================================
- Coverage     79.24%   79.06%   -0.19%     
+ Complexity     1231     1230       -1     
============================================
  Files           110      110              
  Lines          4823     4857      +34     
  Branches        439      439              
============================================
+ Hits           3822     3840      +18     
- Misses          798      813      +15     
- Partials        203      204       +1     
Flag Coverage Δ
unit 79.06% <66.66%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...raceenricher/util/EnrichedEntityAvroConverter.java 0.00% <0.00%> (ø)
...wgenerator/generators/RawServiceViewGenerator.java 0.00% <0.00%> (ø)
...ichment/enrichers/ErrorsAndExceptionsEnricher.java 84.78% <33.33%> (-1.89%) ⬇️
...e/trace/accessor/entities/AvroEntityConverter.java 71.66% <85.71%> (+0.48%) ⬆️
...re/spannormalizer/jaeger/JaegerSpanNormalizer.java 76.92% <88.88%> (+0.92%) ⬆️
...raceenricher/enrichment/AbstractTraceEnricher.java 100.00% <100.00%> (ø)
...richer/enrichment/enrichers/ExitCallsEnricher.java 100.00% <100.00%> (ø)
...er/enrichment/enrichers/HttpAttributeEnricher.java 93.33% <100.00%> (+0.15%) ⬆️
...icher/enrichment/enrichers/TraceStatsEnricher.java 92.30% <100.00%> (+0.30%) ⬆️
...rtrace/traceenricher/util/EntityAvroConverter.java 89.55% <100.00%> (+1.21%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be50ac2...d2253b2. Read the comment docs.

ravisingal
ravisingal previously approved these changes Oct 28, 2021
@github-actions

This comment has been minimized.

@laxman-traceable laxman-traceable merged commit 218e1ae into main Oct 28, 2021
@laxman-traceable laxman-traceable deleted the avro-builder-fix branch October 28, 2021 06:13
@github-actions
Copy link
Copy Markdown

Unit Test Results

  73 files  ±0    73 suites  ±0   1m 6s ⏱️ +5s
386 tests ±0  386 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 218e1ae. ± Comparison against base commit be50ac2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants