feat: add forming grpc reqeuest url if rpc attributes are present#280
Merged
kotharironak merged 4 commits intomainfrom Nov 8, 2021
Merged
feat: add forming grpc reqeuest url if rpc attributes are present#280kotharironak merged 4 commits intomainfrom
kotharironak merged 4 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #280 +/- ##
=========================================
Coverage 79.07% 79.07%
Complexity 1231 1231
=========================================
Files 110 110
Lines 4861 4861
Branches 440 440
=========================================
Hits 3844 3844
Misses 813 813
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
findingrish
approved these changes
Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For RPC methods, we show URL/URI as a combination of
rpc.serviceandrpc.method. The same information is also available as Span Name - https://github.com/open-telemetry/opentelemetry-specification/blob/3e380e249f60c3a5f68746f5e84d10195ba41a79/specification/trace/semantic_conventions/rpc.md#span-nameIt has been observed that spanName is not correctly set on certain scenarios. However, the span contains
rpc.serviceandrpc.methodattribute correctly set. So, as part of this PR, we will first look into RPC attributes if a protocol is grpc, and if those are not present, we will fall back to eventName which is nothing but spanName.Testing
Added unit tests
Checklist: