Conversation
Codecov Report
@@ Coverage Diff @@
## main #282 +/- ##
=========================================
Coverage 79.07% 79.08%
Complexity 1231 1231
=========================================
Files 110 110
Lines 4861 4862 +1
Branches 440 440
=========================================
+ Hits 3844 3845 +1
Misses 813 813
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
| int api_trace_count = 0; | ||
|
|
||
| // count of span | ||
| int span_count = 0; |
Contributor
There was a problem hiding this comment.
Add at the end, after last attribute - api_trace_error_span_count
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kotharironak
requested review from
findingrish,
laxman-traceable and
ravisingal
kotharironak
previously approved these changes
Nov 11, 2021
…ava/org/hypertrace/viewgenerator/generators/SpanEventViewGenerator.java Co-authored-by: kotharironak <53209990+kotharironak@users.noreply.github.com>
…in/avro/SpanEventView.avdl Co-authored-by: kotharironak <53209990+kotharironak@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
||
| int api_trace_error_span_count = 0; | ||
|
|
||
| int span_count = 0; |
Contributor
There was a problem hiding this comment.
span_count -> spans ?
kotharironak
approved these changes
Nov 11, 2021
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref issue : hypertrace/hypertrace-ui#1157