Fixed the span drop criteria parsing logic#287
Merged
avinashkolluru merged 1 commit intomainfrom Nov 18, 2021
Merged
Conversation
- Splitting tag key/value match condition based on the first colon
Codecov Report
@@ Coverage Diff @@
## main #287 +/- ##
============================================
+ Coverage 79.16% 79.20% +0.03%
- Complexity 1238 1239 +1
============================================
Files 111 111
Lines 4881 4880 -1
Branches 443 442 -1
============================================
+ Hits 3864 3865 +1
Misses 813 813
+ Partials 204 202 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the span drop criteria parsing logic which fails if the the tag value has the delimeter(
:)Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist: