refactor: moving out avro checks as a separate job#289
Conversation
Codecov Report
@@ Coverage Diff @@
## main #289 +/- ##
=========================================
Coverage 79.20% 79.20%
Complexity 1239 1239
=========================================
Files 111 111
Lines 4880 4880
Branches 442 442
=========================================
Hits 3865 3865
Misses 813 813
Partials 202 202
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| - name: validate avros | ||
| uses: hypertrace/github-actions/gradle@main | ||
| with: | ||
| args: avroCompatibilityCheck |
There was a problem hiding this comment.
Does this have deps on the build step? If, yes, I will have to add the cache step.
There was a problem hiding this comment.
I can't recall, but you should add the cache step regardless as it caches the gradle binary too. We should probably change the avro plugin so validation does not automatically run on check (the reason for the -x above), but that'd be a bit of a breaking change and could cause repos to stop validating entirely, so this is more reasonable right now
This PR, separate out
avroCompatibilityCheckcompatibility check into a different job.This helps in certain scenarios where we first time adds avro file, and want to skip checks