fix: adds support for default max spans limit helm config#291
Merged
kotharironak merged 2 commits intomainfrom Nov 25, 2021
Merged
fix: adds support for default max spans limit helm config#291kotharironak merged 2 commits intomainfrom
kotharironak merged 2 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #291 +/- ##
============================================
- Coverage 79.60% 79.58% -0.03%
+ Complexity 1268 1265 -3
============================================
Files 112 112
Lines 4937 4937
Branches 451 451
============================================
- Hits 3930 3929 -1
Misses 806 806
- Partials 201 202 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
ravisingal
approved these changes
Nov 25, 2021
This comment has been minimized.
This comment has been minimized.
findingrish
approved these changes
Nov 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described as part of this PR (#290), we have added support for limiting trace size across all tenants.
This PR,
default.max.span.count