Skip to content

chore | remove entities in structured trace graph #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aman-bansal merged 1 commit into from
Sep 28, 2023
Merged

chore | remove entities in structured trace graph #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ hypertrace-grpc-client-utils ={ module = "org.hypertrace.core.grpcutils:grpc-cli
hypertrace-grpc-client-rxUtils = { module = "org.hypertrace.core.grpcutils:grpc-client-rx-utils", version.ref = "hypertrace-grpc-utils"}
hypertrace-serviceFramework-metrics = { module = "org.hypertrace.core.serviceframework:platform-metrics", version.ref = "hypertrace-serviceFramework" }
hypertrace-serviceFramework-framework = { module = "org.hypertrace.core.serviceframework:platform-service-framework", version.ref = "hypertrace-serviceFramework" }
hypertrace-data-model = { module ="org.hypertrace.core.datamodel:data-model", version = "0.1.27" }
hypertrace-data-model = { module ="org.hypertrace.core.datamodel:data-model", version = "0.1.29-SNAPSHOT" }
hypertrace-kafkaStreams-framework = { module = "org.hypertrace.core.kafkastreams.framework:kafka-streams-framework", version.ref = "hypertrace-kafkaStreams" }
hypertrace-kafkaStreams-avroPartitioners = { module = "org.hypertrace.core.kafkastreams.framework:avro-partitioners", version.ref = "hypertrace-kafkaStreams" }
hypertrace-kafkaStreams-weightedGroupPartitioners = { module = "org.hypertrace.core.kafkastreams.framework:weighted-group-partitioner", version.ref = "hypertrace-kafkaStreams" }
Expand Down
31 changes: 7 additions & 24 deletions ...pi/src/main/java/org/hypertrace/traceenricher/trace/util/StructuredTraceGraphBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,41 +56,24 @@ public static StructuredTraceGraph buildGraph(StructuredTrace trace) {

private static void debugGraph(
String logPrefix, StructuredTraceGraph graph, StructuredTrace trace) {
if (null != graph
&& (null == graph.getTraceEntitiesGraph() || null == graph.getTraceEventsGraph())) {
if (null != graph && null == graph.getTraceEventsGraph()) {
LOG.info(
logPrefix
+ "StructuredTraceGraph is not built correctly, trace {}, Is events graph non-null:"
+ " {}."
+ " Is entities graph non-null: {}",
+ " {}.",
trace,
(null != graph.getTraceEventsGraph()),
(null != graph.getTraceEntitiesGraph()));
(null != graph.getTraceEventsGraph()));

// build the graph again and check
StructuredTraceGraph tempGraph = new StructuredTraceGraph(trace);
LOG.info(
logPrefix
+ "Recreating StructuredTraceGraph. Is events graph non-null: {}."
+ " Is entities graph non-null: {}",
(null != tempGraph.getTraceEventsGraph()),
(null != tempGraph.getTraceEntitiesGraph()));
logPrefix + "Recreating StructuredTraceGraph. Is events graph non-null: {}.",
(null != tempGraph.getTraceEventsGraph()));

tempGraph.reCreateTraceEventsGraph(trace);
LOG.info(
logPrefix
+ "Recreating events graph. Is events graph non-null: {}."
+ " Is entities graph non-null: {}",
(null != tempGraph.getTraceEventsGraph()),
(null != tempGraph.getTraceEntitiesGraph()));

tempGraph.reCreateTraceEntitiesGraph(trace);
LOG.info(
logPrefix
+ "Recreating entities graph. Is events graph non-null: {}."
+ " Is entities graph non-null: {}",
(null != tempGraph.getTraceEventsGraph()),
(null != tempGraph.getTraceEntitiesGraph()));
logPrefix + "Recreating events graph. Is events graph non-null: {}.",
(null != tempGraph.getTraceEventsGraph()));
}
}
}