Conversation
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
=========================================
Coverage 79.93% 79.93%
Complexity 1421 1421
=========================================
Files 128 128
Lines 5566 5566
Branches 509 509
=========================================
Hits 4449 4449
Misses 885 885
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.2-all.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.3-all.zip |
There was a problem hiding this comment.
It doesn't really matter, but any particular reason you chose an older 8.x release (8.4 has been out for a couple months)
There was a problem hiding this comment.
8.4 didn't work on my machine failing to fetch distribution from gradle site. Might be connection issue, but happened multiple times
HEAD request to https://services.gradle.org/distributions/gradle-8.4-all.zip failed: response code (401)There was a problem hiding this comment.
huh bizarre, 401. Shouldn't be anything version specific but don't worry about it if it's still failing.
This comment has been minimized.
This comment has been minimized.
|
huh why is build and dependency-check not required? let me fix that. |
| # libssl3 | ||
| CVE-2023-5678 exp:2023-12-31 No newline at end of file |
There was a problem hiding this comment.
didn't report under PR tab but guessing this is the cause (based on other repo observations)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Raw spans grouper is using client utils (the grpc channel registry) without declaring it. It's getting it implicitly from kafka streams framework. Declare the dep and should be good (could also update kafka stream framework, not sure if latest version has the change but we'd want to add the explicit declaration regardless). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 participants
No description provided.