feat: consume entity change events to update cache in eds cached client#441
Merged
kishansairam9 merged 3 commits intomainfrom Nov 28, 2023
Merged
feat: consume entity change events to update cache in eds cached client#441kishansairam9 merged 3 commits intomainfrom
kishansairam9 merged 3 commits intomainfrom
Conversation
kishansairam9
requested review from
SrikarMannepalli,
aaron-steinfeld,
avinashkolluru and
kotharironak
This comment has been minimized.
This comment has been minimized.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
============================================
- Coverage 79.87% 79.50% -0.38%
Complexity 1413 1413
============================================
Files 127 127
Lines 5551 5577 +26
Branches 515 516 +1
============================================
Hits 4434 4434
- Misses 879 905 +26
Partials 238 238
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kishansairam9
commented
Nov 28, 2023
Comment on lines
179
to
189
| public void shutdown() { | ||
| this.grpcChannelRegistry.shutdown(); | ||
| this.entityChangeEventListener.ifPresent( | ||
| listener -> { | ||
| try { | ||
| listener.close(); | ||
| } catch (Exception e) { | ||
|
|
||
| } | ||
| }); | ||
| } |
Author
There was a problem hiding this comment.
This method isn't called really, but added the close for sanity
Contributor
aaron-steinfeld
left a comment
aaron-steinfeld
left a comment
There was a problem hiding this comment.
other than naming lgtm
| return Optional.empty(); | ||
| } | ||
|
|
||
| private static Deserializer<EntityChangeEventKey> getEntityChangeEventKeySerde( |
Contributor
There was a problem hiding this comment.
naming - 'serde' refers to serializer/deserializer, when we lump both together. Given you're only working with deserialization here the naming should be adjusted.
Contributor
There was a problem hiding this comment.
nit - method name too
This comment has been minimized.
This comment has been minimized.
aaron-steinfeld
previously approved these changes
Nov 28, 2023
| return Optional.empty(); | ||
| } | ||
|
|
||
| private static Deserializer<EntityChangeEventKey> getEntityChangeEventKeySerde( |
Contributor
There was a problem hiding this comment.
nit - method name too
aaron-steinfeld
approved these changes
Nov 28, 2023
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.