Skip to content

update gradle to 8.5#446

Merged
kishansairam9 merged 6 commits intomainfrom
remove-version-compat
Jan 18, 2024
Merged

update gradle to 8.5#446
kishansairam9 merged 6 commits intomainfrom
remove-version-compat

Conversation

@kishansairam9
Copy link
Copy Markdown

@kishansairam9 kishansairam9 commented Jan 8, 2024

No description provided.

@github-actions

This comment has been minimized.

Sign in to view
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (18142d6) 79.52% compared to head (2ae0fd1) 79.52%.

❗ Current head 2ae0fd1 differs from pull request most recent head 4dfd7fb. Consider uploading reports for the commit 4dfd7fb to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##               main     #446   +/-   ##
=========================================
  Coverage     79.52%   79.52%           
  Complexity     1414     1414           
=========================================
  Files           127      127           
  Lines          5577     5577           
  Branches        516      516           
=========================================
  Hits           4435     4435           
  Misses          905      905           
  Partials        237      237
Flag Coverage Δ
unit 79.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kishansairam9 kishansairam9 changed the title remove java 11 compat override change drop behaviour to not forward down the pipeline Jan 18, 2024
@kishansairam9 kishansairam9 marked this pull request as ready for review January 18, 2024 07:52
@kishansairam9 kishansairam9 requested a review from a team as a code owner January 18, 2024 07:52
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@kotharironak
Copy link
Copy Markdown
Contributor

kotharironak commented Jan 18, 2024

We don't need it here right now.

@kishansairam9 kishansairam9 changed the title change drop behaviour to not forward down the pipeline update gradle to 8.5 Jan 18, 2024
@kishansairam9 kishansairam9 enabled auto-merge (squash) January 18, 2024 12:57
@github-actions

This comment has been minimized.

Sign in to view
aaron-steinfeld
aaron-steinfeld reviewed Jan 18, 2024
View reviewed changes
Comment thread build.gradle.kts

pluginManager.withPlugin("java") {
configure<JavaPluginExtension> {
sourceCompatibility = JavaVersion.VERSION_11
Copy link
Copy Markdown
Contributor

@aaron-steinfeld aaron-steinfeld Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can leave this as-is.

Copy link
Copy Markdown
Author

@kishansairam9 kishansairam9 Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a problem if I remove it though? Do we default to java 11 in CI

Copy link
Copy Markdown
Contributor

@aaron-steinfeld aaron-steinfeld Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If removed it just means it defaults to the JVM of the environment it runs in. This should always have been specified in some way (toolchain, in modern gradle) but is missing in a lot of projects. The default in CI is java 11, yes. But we don't want to rely on that assumption for every developer's machine. In other words, this allows a user to run this build with a later jdk without issue.

@github-actions

This comment has been minimized.

Sign in to view
@kishansairam9 kishansairam9 merged commit b9f458f into main Jan 18, 2024
@kishansairam9 kishansairam9 deleted the remove-version-compat branch January 18, 2024 15:51
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 18, 2024

Unit Test Results

  78 files  ±0    78 suites  ±0   1m 7s ⏱️ +2s
418 tests ±0  418 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit b9f458f. ± Comparison against base commit 18142d6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaron-steinfeld aaron-steinfeld aaron-steinfeld approved these changes

@SrikarMannepalli SrikarMannepalli Awaiting requested review from SrikarMannepalli

@kotharironak kotharironak Awaiting requested review from kotharironak

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kishansairam9 @kotharironak @aaron-steinfeld