Skip to content

Add new otel attribute for Rabbitmq backend#447

Merged
sanket-mundra merged 3 commits intomainfrom
sanket/fixOtelAttributeForRabbitmqBackend
Feb 5, 2024
Merged

Add new otel attribute for Rabbitmq backend#447
sanket-mundra merged 3 commits intomainfrom
sanket/fixOtelAttributeForRabbitmqBackend

Conversation

@sanket-mundra
Copy link
Copy Markdown
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@sanket-mundra sanket-mundra requested a review from a team as a code owner January 30, 2024 11:00
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc4d7c0) 79.53% compared to head (6e4e0bc) 79.53%.
Report is 1 commits behind head on main.

❗ Current head 6e4e0bc differs from pull request most recent head c3d7bd1. Consider uploading reports for the commit c3d7bd1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #447   +/-   ##
=========================================
  Coverage     79.53%   79.53%           
  Complexity     1427     1427           
=========================================
  Files           130      130           
  Lines          5692     5692           
  Branches        533      533           
=========================================
  Hits           4527     4527           
  Misses          912      912           
  Partials        253      253           
Flag Coverage Δ
unit 79.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions

This comment has been minimized.

@sanket-mundra sanket-mundra merged commit 475aca8 into main Feb 5, 2024
@sanket-mundra sanket-mundra deleted the sanket/fixOtelAttributeForRabbitmqBackend branch February 5, 2024 09:13
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2024

Unit Test Results

  79 files  ±0    79 suites  ±0   1m 8s ⏱️ -2s
420 tests ±0  420 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 475aca8. ± Comparison against base commit 4fa3a54.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants