fix: path fetching for home paths Urls#448
Merged
sanket-mundra merged 3 commits intomainfrom Feb 5, 2024
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
=========================================
Coverage 79.53% 79.53%
Complexity 1427 1427
=========================================
Files 130 130
Lines 5692 5692
Branches 533 533
=========================================
Hits 4527 4527
Misses 912 912
Partials 253 253
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
skjindal93
approved these changes
Feb 2, 2024
| // Ends with "/" and it's not home page path | ||
| return s.endsWith(SLASH) && s.length() > 1 ? s.substring(0, s.length() - 1) : s; | ||
| private static String removeTrailingSlashes(String url) { | ||
| // if it's home page path, then return / |
Contributor
There was a problem hiding this comment.
Suggested change
| // if it's home page path, then return / | |
| // if it's root URL, then return / |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
saxenakshitiz
approved these changes
Feb 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix for creation of APIs from url like:
http://www.google.com/andhttp://www.google.comTesting
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.