Gateway client deadline config#99
Merged
kotharironak merged 5 commits intohypertrace:mainfrom Jul 11, 2021
Merged
Conversation
suddendust
requested review from
findingrish,
kotharironak,
laxmanchekka and
ravisingal
as code owners
This was referenced Jul 9, 2021
… added fallback configuration
…ice.deadline -> gateway.service.timeout)
Contributor
kotharironak
left a comment
kotharironak
left a comment
There was a problem hiding this comment.
you may have to update submodules once the dependent PR merge.
Contributor
Author
Done @kotharironak thanks |
kotharironak
approved these changes
Jul 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These changes are in context of: hypertrace/hypertrace-core-graphql#69. Currently, we hardcode the deadline as 10s. Now, GATEWAY_SERVICE_DEADLINE is read from application.conf
Testing
Test and deployed the application locally.
Checklist: