Skip to content

feat: replacing components with hover over gray#1020

Merged
palbizu merged 2 commits intomainfrom
HoverOverGray
Jul 26, 2021
Merged

feat: replacing components with hover over gray#1020
palbizu merged 2 commits intomainfrom
HoverOverGray

Conversation

@palbizu
Copy link
Copy Markdown
Contributor

@palbizu palbizu commented Jul 23, 2021

Description

Replacing hover over and select in the following components:

  • Table
  • Sequence Chart
  • Card list

Note: this change was suggested by @anandtiwary so he should review it.

Testing

Visual.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner July 23, 2021 22:46
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 23, 2021

Codecov Report

Merging #1020 (5996da1) into main (bdc8c4b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1020   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files         820      820           
  Lines       16863    16863           
  Branches     2190     2190           
=======================================
  Hits        14344    14344           
  Misses       2488     2488           
  Partials       31       31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdc8c4b...5996da1. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit b7d4569 into main Jul 26, 2021
@palbizu palbizu deleted the HoverOverGray branch July 26, 2021 18:49
@github-actions
Copy link
Copy Markdown

Unit Test Results

    4 files  262 suites   17m 7s ⏱️
945 tests 945 ✔️ 0 💤 0 ❌
952 runs  952 ✔️ 0 💤 0 ❌

Results for commit b7d4569.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants