Skip to content

chore: set up node 16 in workflows#1077

Merged
anandtiwary merged 14 commits intomainfrom
node-16
Aug 19, 2021
Merged

chore: set up node 16 in workflows#1077
anandtiwary merged 14 commits intomainfrom
node-16

Conversation

@itssharmasandeep
Copy link
Copy Markdown
Contributor

No description provided.

@itssharmasandeep itssharmasandeep requested a review from a team as a code owner August 19, 2021 16:57
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 19, 2021

Codecov Report

Merging #1077 (5e4314a) into main (9b69822) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1077   +/-   ##
=======================================
  Coverage   85.08%   85.08%           
=======================================
  Files         822      822           
  Lines       16924    16924           
  Branches     2045     2045           
=======================================
  Hits        14399    14399           
  Misses       2494     2494           
  Partials       31       31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b69822...5e4314a. Read the comment docs.

@github-actions

This comment has been minimized.

- name: Check out code
uses: actions/checkout@v2

- name: Set up Node 16
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Or should we use a different build image @aaron-steinfeld?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubuntu 20.04 is pretty much their newest, I believe https://github.com/actions/virtual-environments#available-environments - and it uses Npm 6.14.14, Node 14.17.5

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm assuming updating node in this way updates npm too)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. it should install npm

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to merge this.

@anandtiwary anandtiwary merged commit 36aaeea into main Aug 19, 2021
@anandtiwary anandtiwary deleted the node-16 branch August 19, 2021 18:34
@github-actions
Copy link
Copy Markdown

Unit Test Results

    4 files  ±0  263 suites  ±0   18m 15s ⏱️ + 1m 58s
947 tests ±0  947 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
954 runs  ±0  954 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 36aaeea. ± Comparison against base commit 9b69822.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants