feat: make page header configurable to persist active tab#1147
Merged
jake-bassett merged 8 commits intomainfrom Sep 27, 2021
Merged
feat: make page header configurable to persist active tab#1147jake-bassett merged 8 commits intomainfrom
jake-bassett merged 8 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
- Coverage 85.05% 85.02% -0.03%
==========================================
Files 829 829
Lines 17152 17175 +23
Branches 2228 2233 +5
==========================================
+ Hits 14588 14603 +15
- Misses 2533 2540 +7
- Partials 31 32 +1
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jake-bassett
requested review from
alok-traceable,
arjunlalb,
itssharmasandeep and
palbizu
anandtiwary
reviewed
Sep 26, 2021
| ) {} | ||
|
|
||
| public ngOnInit(): void { | ||
| this.getPreferences().subscribe(preferences => { |
Contributor
There was a problem hiding this comment.
Do we need to unsubscribe this?
…nally-persist-page-header-active-tab
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
anandtiwary
reviewed
Sep 27, 2021
| startWith(undefined), | ||
| map(() => this.findActiveTab()) | ||
| map(() => this.findActiveTab()), | ||
| tap(activeTab => this.tabChange.emit(activeTab?.path)) |
Contributor
There was a problem hiding this comment.
I wonder if this would emit duplicate events. May be we can put distinctUntilChanged operator before the tap.
…nally-persist-page-header-active-tab
anandtiwary
approved these changes
Sep 27, 2021
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This allows consumers of the page header to provide a unique persitanceId that will turn on saving the active tab to browser storage.