fix: hover over a selected table changed color#774
Conversation
| border-top: 1px solid $blue-2; | ||
|
|
||
| &.hovered-row { | ||
| background: $blue-2; |
There was a problem hiding this comment.
This is for hover on a selected row. Has the ux changed for this? At all other place, we make the color darker on hover. This would make it inconsistent with similar behavior on a card list
There was a problem hiding this comment.
Yeah. So hover on these rows right now is a little off. We go darker on buttons typically, but with rows and other navigation items the hover I think would be better suited to always be the same.
Alternatively, I could accept that a hover on a selected row doesn't change anything. Instead it stays as a selected state.
There was a problem hiding this comment.
I am fine with whatever you decide on visual aspects. I just want to share that this change require similar modifications to
- Sequence chart: d3 row hover. Without this waterfall would appear broken.
- Card lists
@michael-traceable Could you confirm we need to apply styling at these two locations too?
There was a problem hiding this comment.
Good call! Yes, waterfall should match because it's similar structure (table format)... The card list we can match as well, however, I believe I also have a ticket that the hover on that should just be the shadow and no gray, but it doesn't bother me too much.
There was a problem hiding this comment.
Should we bundle all of these changes at once? I kind of lean towards yes so there are no inconsistencies.
There was a problem hiding this comment.
I agree. @palbizu Can we bundle all the changes together in the same PR?
There was a problem hiding this comment.
@anandtiwary just to double-check. I should apply the same pattern to
1- Tables (I already did it in this PR)
2- Sequence charts d3 row hover
3- Card lists
Codecov Report
@@ Coverage Diff @@
## main #774 +/- ##
=======================================
Coverage 85.38% 85.38%
=======================================
Files 789 789
Lines 16145 16145
Branches 2060 2060
=======================================
Hits 13785 13785
Misses 2329 2329
Partials 31 31 Continue to review full report at Codecov.
|
4 participants
Description
The background color and borders were changed in hover over on a selected table.
Testing
Visual Testing
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.