Skip to content

feat: adding new icons and updating link style#933

Merged
anandtiwary merged 3 commits intomainfrom
add-icons-fix-link
Jun 16, 2021
Merged

feat: adding new icons and updating link style#933
anandtiwary merged 3 commits intomainfrom
add-icons-fix-link

Conversation

@anandtiwary
Copy link
Copy Markdown
Contributor

@anandtiwary anandtiwary commented Jun 16, 2021

Description

Please include a summary of the change, motivation and context.
feat: adding new icons and updating link style

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner June 16, 2021 05:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 16, 2021

Codecov Report

Merging #933 (c42c793) into main (dd6592d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #933   +/-   ##
=======================================
  Coverage   85.14%   85.14%           
=======================================
  Files         806      806           
  Lines       16638    16638           
  Branches     2094     2094           
=======================================
  Hits        14166    14166           
  Misses       2440     2440           
  Partials       32       32           
Impacted Files Coverage Δ
...ts/assets-library/src/icons/icon-library.module.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd6592d...c42c793. Read the comment docs.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor

@itssharmasandeep itssharmasandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@anandtiwary anandtiwary merged commit 6a049e3 into main Jun 16, 2021
@anandtiwary anandtiwary deleted the add-icons-fix-link branch June 16, 2021 05:56
@github-actions
Copy link
Copy Markdown

Unit Test Results

    4 files  ±0  258 suites  ±0   15m 7s ⏱️ +38s
929 tests ±0  929 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
935 runs  ±0  935 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6a049e3. ± Comparison against base commit dd6592d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants