ASP-2043: Add serviceConfig support to GrpcChannelConfig for gRPC built-in retry#93
Open
kunalvaswani123 wants to merge 1 commit intohypertrace:mainfrom
Open
ASP-2043: Add serviceConfig support to GrpcChannelConfig for gRPC built-in retry#93kunalvaswani123 wants to merge 1 commit intohypertrace:mainfrom
kunalvaswani123 wants to merge 1 commit intohypertrace:mainfrom
Conversation
kunalvaswani123
force-pushed
the
ASP-2043
branch
from
6b8b9a2 to
3672e14
Compare
kunalvaswani123
changed the title
kunalvaswani123
force-pushed
the
ASP-2043
branch
from
766944b to
a545450
Compare
…lt-in retry - Add optional serviceConfig field to GrpcChannelConfig - Wire defaultServiceConfig() + enableRetry() in GrpcChannelRegistry when serviceConfig is set - Add test verifying channels with different service configs are cached independently Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> AI-Session-Id: 75f3864c-dc2c-4e44-b4f3-b23c980f2ea6 AI-Tool: claude-code AI-Model: unknown
kunalvaswani123
force-pushed
the
ASP-2043
branch
from
a545450 to
4fe9c35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serviceConfig: Map<String, Object>field toGrpcChannelConfigdefaultServiceConfig()+enableRetry()inGrpcChannelRegistry.configureAndBuildChannel()This allows callers to pass a gRPC service config with a
retryPolicyblock directly through the channel config, enabling gRPC's built-in retry without any additional interceptor dependencies.Test plan
grpc-client-utilstests passserviceConfigset🤖 Generated with Claude Code