Add JAX-RS 2 client body capture#159
Merged
pavolloffay merged 9 commits intohypertrace:mainfrom Dec 9, 2020
Merged
Conversation
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
pavolloffay
commented
Dec 9, 2020
| .getAttributes() | ||
| .get(HypertraceSemanticAttributes.httpResponseHeader("test-response-header"))); | ||
| Assertions.assertEquals( | ||
| "{key1=[value1], key2=[value2]}", |
Member
Author
There was a problem hiding this comment.
@davexroth this is the attribute value for the request body with URL encoded content type. Should it be captured in some other form e.g. foo=bar&baz=bar?
Member
Author
There was a problem hiding this comment.
changed to foo=bar&baz=bar that is supported by the platform.
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
pavolloffay
commented
Dec 9, 2020
| return entity; | ||
| } | ||
|
|
||
| if (currentSpan.isRecording()) { |
Member
Author
There was a problem hiding this comment.
another example when client span is finished before the response entity is available. Related to hypertrace/hypertrace-ingester#81
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay p.loffay@gmail.com