Skip to content

Add optional maxConnectionAge and maxConnectionAgeGrace support to G… #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gg-harness merged 2 commits into from
Apr 15, 2026
Merged

Add optional maxConnectionAge and maxConnectionAgeGrace support to G… #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87b1235
Add optional maxConnectionAge and maxConnectionAgeGrace support to G…
Gg-harness Apr 14, 2026
16242c6
Change maxConnectionAge fields from seconds to Duration
Gg-harness Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...src/main/java/org/hypertrace/core/serviceframework/grpc/GrpcPlatformServerDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package org.hypertrace.core.serviceframework.grpc;

import io.grpc.ServerInterceptor;
import java.time.Duration;
import java.util.Collection;
import java.util.List;
import lombok.AccessLevel;
Expand All @@ -17,6 +18,8 @@ public class GrpcPlatformServerDefinition {
int port;
int maxInboundMessageSize;
@Builder.Default int maxRstPerMinute = 500;
@Builder.Default Duration maxConnectionAge = Duration.ZERO;
@Builder.Default Duration maxConnectionAgeGrace = Duration.ZERO;
@Singular Collection<GrpcPlatformServiceFactory> serviceFactories;
@Singular List<ServerInterceptor> serverInterceptors;
}
7 changes: 7 additions & 0 deletions ...src/main/java/org/hypertrace/core/serviceframework/grpc/GrpcPlatformServiceContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,13 @@ private ServerBuilder<?> initializeBuilder(GrpcPlatformServerDefinition serverDe
if (serverDefinition.getMaxRstPerMinute() > 0) {
builder.maxRstFramesPerWindow(serverDefinition.getMaxRstPerMinute(), 60);
}
if (!serverDefinition.getMaxConnectionAge().isZero()) {
builder.maxConnectionAge(serverDefinition.getMaxConnectionAge().toMillis(), MILLISECONDS);
}
if (!serverDefinition.getMaxConnectionAgeGrace().isZero()) {
builder.maxConnectionAgeGrace(
serverDefinition.getMaxConnectionAgeGrace().toMillis(), MILLISECONDS);
}
// add micrometer-grpc interceptor to collect server metrics.
builder.intercept(
new MetricCollectingServerInterceptor(
Expand Down
Loading