Conversation
aaron-steinfeld
requested review from
avinashkolluru,
surajpuvvada and
tim-mwangi
as code owners
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #50 +/- ##
=========================================
Coverage 69.08% 69.08%
Complexity 106 106
=========================================
Files 15 15
Lines 566 566
Branches 33 33
=========================================
Hits 391 391
Misses 155 155
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. |
This comment has been minimized.
This comment has been minimized.
|
|
||
| @AllArgsConstructor | ||
| public class StandAloneHttpContainerEnvironment implements HttpContainerEnvironment { | ||
| @Getter private final GrpcChannelRegistry channelRegistry; |
There was a problem hiding this comment.
Is this for GRPC clients used by the HTTP server?
There was a problem hiding this comment.
Correct, even though they're hosting HTTP (or more specifically, REST) APIs, they're still communicating downstream to GRPC services.
|
|
||
| @Override | ||
| public boolean healthCheck() { | ||
| return true; |
There was a problem hiding this comment.
Nothing more in this one?
There was a problem hiding this comment.
I resisted 😉 let's file this under the Future Work section (it's not a regression and it's still overridable - and more importantly, we didn't really have a ready replacement lined up like we did with GRPC)
2 participants
Description
Similar to previously added grpc framework, a small wrapper around existing code to allow composing one or more services, and generally make server building simpler.
Testing
Ran integration tests with a service running on this implementation
Example service using new framework: hypertrace/hypertrace-core-graphql#105