This repository was archived by the owner on Nov 12, 2024. It is now read-only.
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #80 +/- ##
============================================
+ Coverage 75.54% 75.77% +0.22%
Complexity 148 148
============================================
Files 15 15
Lines 642 648 +6
Branches 64 64
============================================
+ Hits 485 491 +6
Misses 118 118
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| testImplementation("org.mockito:mockito-core:5.2.0") | ||
| testImplementation("org.apache.kafka:kafka-streams-test-utils:7.2.1-ccs") | ||
| testRuntimeOnly("org.apache.logging.log4j:log4j-slf4j-impl:2.20.0") | ||
| testRuntimeOnly("org.apache.logging.log4j:log4j-slf4j2-impl:2.20.0") |
Contributor
There was a problem hiding this comment.
the api on line 22 is slf4j1, why are we changing to bind the slf4j2 impl?
Contributor
Author
There was a problem hiding this comment.
Getting this error with slf4j and moving to slf4j2 resolved this.
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details.
SLF4J: Class path contains SLF4J bindings targeting slf4j-api versions 1.7.x or earlier.
SLF4J: Ignoring binding found at [jar:file:/Users/laxman/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-slf4j-impl/2.20.0/7ab4f082fd162f60afcaf2b8744a3d959feab3e8/log4j-slf4j-impl-2.20.0.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See https://www.slf4j.org/codes.html#ignoredBindings for an explanation.
Contributor
There was a problem hiding this comment.
ah you're right, my mistake - I'm not sure what I was looking at. Line 22 api declaration is slf4j2 not 1.
aaron-steinfeld
approved these changes
Sep 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.