feat(encryption): allow custom loading of JWK sets#214
Merged
grmeyer-hw-dev merged 2 commits intohyperwallet:masterfrom Jul 4, 2024
sp00m:custom-keyset-load
Merged
feat(encryption): allow custom loading of JWK sets#214grmeyer-hw-dev merged 2 commits intohyperwallet:masterfrom sp00m:custom-keyset-load
grmeyer-hw-dev merged 2 commits intohyperwallet:masterfrom
sp00m:custom-keyset-load
Conversation
Collaborator
|
Hi @sp00m Thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would allow us to cache the JWK sets to reduce the IOs and improve performances, for instance with something along those lines:
Let me know if you think of a better approach while ensuring backward compatibility, thanks 🙌